Merged
Conversation
The screen.capture() and captureRegion() methods don't write to the path we expect - they return the actual saved path. The code was trying to read from a temp file path that never had the screenshot data. Fix: Use grab()/grabRegion() which return Image objects, then call toPNG() to get the buffer directly. This eliminates temp file issues. Also removes unused imports (os, fs/promises) and tempFile() function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ENOENT error when taking screenshots.
The screen.capture() methods return the actual saved path, not write to the path we pass. Using grab()/grabRegion() with toPNG() gets the buffer directly without temp file issues.