Inconsistency in when BeanContainer.createInstance() may be called

[Azquelt]

The Javadoc for BeanContainer.createInstance() defines its behaviour when called during AfterBeanDiscovery. The Javadoc for BeanManager says it's not valid before AfterBeanDiscovery.

However, the spec (3.9.1) says that it's not valid before AfterDeploymentValidation which is fired after AfterBeanDiscovery.

The spec and the Javadoc disagree here, which one should be changed?

[Azquelt]

It looks like the TCK asserts that it can't be called before AfterDeploymentValidation (i.e. matching what the spec says)

[manovotn]

It looks like the TCK asserts that it can't be called before AfterDeploymentValidation (i.e. matching what the spec says)

This is what I would expect to be the correct behavior.
Weld should behave that way as well, although we skip this verification in non-portable mode.

The Javadoc for BeanContainer.createInstance() defines its behaviour when called during AfterBeanDiscovery.

Interestingly, the same javadoc, just a few lines below, also defines that it throws an exception if invoked before ADV :)

[Azquelt]

Weld should behave that way as well

It does :)

Interestingly, the same javadoc, just a few lines below, also defines that it throws an exception if invoked before ADV :)

Huh, so it does.

I guess it's just the Javadoc that needs cleaned up then. I will check for any other references and make a PR.

[manovotn]

Thanks!