Programmatic lookup improvements, introduce Handle interface.#534
Merged
manovotn merged 1 commit intojakartaee:masterfrom Oct 6, 2021
Merged
Programmatic lookup improvements, introduce Handle interface.#534manovotn merged 1 commit intojakartaee:masterfrom
manovotn merged 1 commit intojakartaee:masterfrom
Conversation
Contributor
Author
|
@Ladicek @mkouba I didn't include the |
manovotn
force-pushed
the
handlerApi
branch
2 times, most recently
from
ac89491 to
786b223
Compare
Ladicek
reviewed
Sep 27, 2021
Ladicek
reviewed
Sep 27, 2021
Member
|
I would stay away from the priority comparator, if only because of the |
manovotn
force-pushed
the
handlerApi
branch
from
786b223 to
595d43d
Compare
Contributor
Author
|
@Ladicek could you please green-stamp this? Unless there is something else you want me to change of course. |
Ladicek
approved these changes
Oct 6, 2021
Member
|
Done. Sorry, totally forgot about this! |
Ladicek
requested changes
Oct 6, 2021
Member
Ladicek
left a comment
Ladicek
left a comment
There was a problem hiding this comment.
Actually I know that I wanted something changed :-) The Handle.getBean() method return type.
Contributor
Author
Ah, right, good point! |
Ladicek
approved these changes
Oct 6, 2021
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #521
BTW, I will also prepare a draft of a TCK test based on what we had in Weld.