Remove the notion of version from Packaging and deployment for CDI Full#549
Merged
manovotn merged 1 commit intojakartaee:masterfrom Oct 27, 2021
Merged
Conversation
Member
|
This is certainly a clean way to do it, though it obviously limits the number of existing bean archives that are portable to Lite even more. I'm like +0.5 to this. |
Contributor
Author
|
Converted back to draft. In the meeting we have decided to do this differently. I will rework this PR accordingly. |
Emily-Jiang
approved these changes
Oct 26, 2021
manovotn
force-pushed
the
fixBeansXmlDefinition
branch
from
0e44d54 to
a8267ab
Compare
manovotn
force-pushed
the
fixBeansXmlDefinition
branch
from
a8267ab to
485c6e7
Compare
manovotn
changed the title
Ladicek
approved these changes
Oct 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier today me and @Ladicek discussed that there is a potential hole in between Lite and Full with regards to
beans.xml.You can have
beans.xmlthat is not an empty file and declares the<beans>element but does not specifyversionandbean-discovery-mode.Such archive would then end up with
annotateddiscovery in Lite but withallin Full (due to not having a version).This PR is a proposed fix for that.