Separate the language model to a dedicated module#553
Separate the language model to a dedicated module#553Ladicek merged 1 commit intojakartaee:masterfrom
Conversation
Ladicek
force-pushed
the
separate-lang-model
branch
from
83b005d to
5986731
Compare
manovotn
left a comment
manovotn
left a comment
There was a problem hiding this comment.
Dropped some comments.
I have no idea about those licenses and what needs to be there. I guess you just copied what other modules use ATM?
| <version>4.0.0-SNAPSHOT</version> | ||
| </parent> | ||
|
|
||
| <artifactId>jakarta.enterprise.lang-model</artifactId> |
There was a problem hiding this comment.
Do we need to prepend jakarta.enterprise?
Just having lang-model sounds a lot better to me.
There was a problem hiding this comment.
If you look at Maven Central, you'll find both jakarta.enterprise:cdi-api and jakarta.enterprise:jakarta.enterprise.cdi-api. I don't know if that was a mistake or not, but it seems that the shorter form was considered and rejected.
There was a problem hiding this comment.
I noticed that but TBF I don't know what the history was. I just thought it would be more readable the shorter it is.
| <artifactId>jakarta.enterprise.lang-model</artifactId> | ||
| <packaging>jar</packaging> | ||
|
|
||
| <name>CDI Language Model</name> |
There was a problem hiding this comment.
Since we want to make this potentially usable elsewhere, I'd say it is just Language Model Abstraction
There was a problem hiding this comment.
I wanted to avoid something like "Jakarta Language Model", because that's not what it is at the moment, and just "Language Model" seems strange. I attribute this to CDI on a few places, but it's worded in a way that generalizing to Jakarta should be straightforward (if that's what it ends up being).
| <packaging>jar</packaging> | ||
|
|
||
| <name>CDI Language Model</name> | ||
| <description>Build Compatible (Reflection-Free) Java Language Model for CDI</description> |
There was a problem hiding this comment.
Again, would drop CDI. Alternatively, change the wording to say that CDI is an example of framework leveraging this language model?
Also add `package-info.java` and `overview.html` files, so that the generated javadoc looks a bit better.
Ladicek
force-pushed
the
separate-lang-model
branch
from
5986731 to
df6bd5f
Compare
|
@Ladicek feel free to merge this. My comments were minor things anyway. |
|
Thanks! |
Ladicek
added
Lite
2 participants
No description provided.