Update asciidoc plugins, config#559
Merged
starksm64 merged 5 commits intojakartaee:masterfrom Nov 18, 2021
Merged
Conversation
Update the root readme Signed-off-by: starksm64 <starksm64@gmail.com>
Signed-off-by: starksm64 <starksm64@gmail.com>
manovotn
reviewed
Nov 18, 2021
Member
|
I looked into updating Asciidoctor when prototyping specref and I did it like this.
...
<properties>
<asciidoctor-maven.version>2.2.1</asciidoctor-maven.version>
<asciidoctorj.version>2.5.2</asciidoctorj.version> <!-- <<<<< added line <<<<< -->
<asciidoctorj-pdf.version>1.6.0</asciidoctorj-pdf.version>
...
</properties>
...
...
<plugin>
<groupId>org.asciidoctor</groupId>
<artifactId>asciidoctor-maven-plugin</artifactId>
<version>${asciidoctor-maven.version}</version>
<dependencies>
<!-- >>>>> added dependency >>>>> -->
<dependency>
<groupId>org.asciidoctor</groupId>
<artifactId>asciidoctorj</artifactId>
<version>${asciidoctorj.version}</version>
</dependency>
<!-- <<<<< added dependency <<<<< -->
<dependency>
<groupId>org.asciidoctor</groupId>
<artifactId>asciidoctorj-pdf</artifactId>
<version>${asciidoctorj-pdf.version}</version>
</dependency>
</dependencies>
...
</plugin>
<configuration>
<sourceDirectory>src/main/asciidoc</sourceDirectory> <!-- otherwise warnings are printed -->
<sourceDocumentName>cdi-spec.asciidoc</sourceDocumentName>
<attributes>
<license>${license-file}</license>
<revremark>${revremark}</revremark>
<imagesdir>images</imagesdir>
<source-highlighter>coderay</source-highlighter>
</attributes>
</configuration> |
…ory and imagesdir Signed-off-by: starksm64 <starksm64@gmail.com>
Signed-off-by: starksm64 <starksm64@gmail.com>
Member
Author
|
I have updated the plugin configuration to use the explicit asciidoctorj.version setting and added the addition configuration/attribute changes. The test build with this PR shows no errors/warnings: |
Ladicek
approved these changes
Nov 18, 2021
Member
|
I vaguely recall seeing a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #558