Skip to content

Move getInjectableReference method from BeanContainer to BeanManager#574

Merged
manovotn merged 1 commit intojakartaee:masterfrom
manovotn:issue568
Dec 8, 2021
Merged

Move getInjectableReference method from BeanContainer to BeanManager#574
manovotn merged 1 commit intojakartaee:masterfrom
manovotn:issue568

Conversation

@manovotn
Copy link
Copy Markdown
Contributor

@manovotn manovotn commented Dec 7, 2021

Fixes #568

@manovotn manovotn requested a review from Ladicek December 7, 2021 13:27
@Ladicek Ladicek requested a review from graemerocher December 7, 2021 15:15
@Emily-Jiang
Copy link
Copy Markdown
Contributor

Can you explain why the method needs to be moved to BeanManager?

@manovotn
Copy link
Copy Markdown
Contributor Author

manovotn commented Dec 8, 2021

@Emily-Jiang the linked issue explains it - in short it is very hard (in Lite) to get hold of InjectionPoint which is a parameter needed for this method. Therefore, you are highly unlikely to invoke this method in purely CDI Lite.
Note that Lite impls can still implement it if they wish to since we allow them to use BeanManager which will retain this method anyway.

@manovotn manovotn merged commit 520bad1 into jakartaee:master Dec 8, 2021
@manovotn manovotn deleted the issue568 branch December 8, 2021 08:04
@Emily-Jiang
Copy link
Copy Markdown
Contributor

okay, thanks @manovotn ! For some strange reason, I did not see the linked issue on this PR when I looked. I might have missed it. Your explanation makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BeanContainer#getInjectableReference should probably be on BeanManager instead

3 participants