Skip to content

Remove dependency on JTA API#609

Merged
starksm64 merged 1 commit intojakartaee:masterfrom
manovotn:issue608
May 18, 2022
Merged

Remove dependency on JTA API#609
starksm64 merged 1 commit intojakartaee:masterfrom
manovotn:issue608

Conversation

@manovotn
Copy link
Copy Markdown
Contributor

Fixes #608

This is one of the ways to address it as we don't really need the dependency on JTA apart from javadoc of a single class.

(FYI @arjantijms)

@manovotn manovotn requested review from Ladicek and starksm64 May 16, 2022 06:31
@manovotn
Copy link
Copy Markdown
Contributor Author

manovotn commented May 16, 2022

I have also noticed that we are declaring EJB API dependency directly inside maven javadoc plugin.
Maybe that would be a better option? We'd still be keeping the cyclic dep and would, by definiton, have an outdated version there on release.

@Ladicek
Copy link
Copy Markdown
Member

Ladicek commented May 16, 2022

Sounds like a good idea, but I wouldn't mind if we got rid of the EJB dependency as well :-)

@Ladicek
Copy link
Copy Markdown
Member

Ladicek commented May 16, 2022

Not merging yet, as I assume we'll wanna discuss this on the CDI call tomorrow.

@manovotn
Copy link
Copy Markdown
Contributor Author

Sounds like a good idea, but I wouldn't mind if we got rid of the EJB dependency as well :-)

Yeah, that's exactly what I wanted to bring up in the meeting tomorrow

@arjantijms
Copy link
Copy Markdown

Thanks!

@starksm64 starksm64 merged commit 6e5d04e into jakartaee:master May 18, 2022
@manovotn manovotn deleted the issue608 branch May 18, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dependency on outdated JTA API

5 participants