add BuildServicesResolver.setBuildServices()#617
Conversation
api/src/main/java/jakarta/enterprise/inject/build/compatible/spi/BuildServicesResolver.java
Show resolved
Hide resolved
api/src/main/java/jakarta/enterprise/inject/build/compatible/spi/BuildServicesResolver.java
Show resolved
Hide resolved
manovotn
left a comment
There was a problem hiding this comment.
@Ladicek should we also include the policy to only be able to set the impl only once?
We do the same thing for CDI providers.
I considered that, but contrary to your statement (and contrary to the javadoc you link to), I didn't find |
Indeed, you're correct. I only read the javadoc and assumed that. |
92aa067 to
3b56b49
Compare
|
|
||
| if (!loader.iterator().hasNext()) { | ||
| throw new IllegalStateException("Unable to locate AnnotationBuilderFactory implementation"); | ||
| throw new IllegalStateException("Unable to locate BuildServices implementation"); |
There was a problem hiding this comment.
| throw new IllegalStateException("Unable to locate BuildServices implementation"); | |
| throw new IllegalStateException("Unable to locate a BuildServices implementation"); |
|
This change was discussed during the meeting and agreed on it as a way forward. @arjantijms do you need a service release with this fix or are you going to use the workaround mentioned in the issue? |
I will use the workaround mentioned in the issue for now, so a service release is not strictly needed from my part. |
No description provided.