Move the specification of BeanManager.getInjectableReference() to CDI Full#676
Merged
Ladicek merged 1 commit intojakartaee:masterfrom May 31, 2023
Merged
Conversation
… Full We previously [1] moved the `getInjectableReference()` from the `BeanContainer` interface to the `BeanManager` [2], but did not update the specification text accordingly. Thus, the method is specified in the CDI Lite part of the spec, but it in fact belongs to CDI Full. This commit moves the spec text around to fix that. Additionally, this commit removes the declaration of `resolveObserverMethods()` from `BeanManager`, because that just overrides the same declaration that is present on `BeanContainer`. Finally, this commit moves the declaration of `getInjectableReference()` from the end of the `BeanManager` source code to the beginning, for symmetry with the `BeanContainer` declaration and to restore the previous layout. [1] jakartaee@520bad1 [2] jakartaee#568
Member
Author
|
I've also checked the CDI TCK and all references to |
manovotn
approved these changes
May 31, 2023
Contributor
manovotn
left a comment
manovotn
left a comment
There was a problem hiding this comment.
Thanks, this is an oversight from previously done changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously [1] moved the
getInjectableReference()from theBeanContainerinterface to theBeanManager[2], but did not update the specification text accordingly. Thus, the method is specified in the CDI Lite part of the spec, but it in fact belongs to CDI Full. This commit moves the spec text around to fix that.Additionally, this commit removes the declaration of
resolveObserverMethods()fromBeanManager, because that just overrides the same declaration that is present onBeanContainer.Finally, this commit moves the declaration of
getInjectableReference()from the end of theBeanManagersource code to the beginning, for symmetry with theBeanContainerdeclaration and to restore the previous layout.[1] 520bad1
[2] #568