Remove mention of context activation from AfterDeploymentValidation event#705
Merged
manovotn merged 1 commit intojakartaee:mainfrom Nov 29, 2023
Merged
Remove mention of context activation from AfterDeploymentValidation event#705manovotn merged 1 commit intojakartaee:mainfrom
manovotn merged 1 commit intojakartaee:mainfrom
Conversation
Ladicek
approved these changes
Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #454
This doesn't change functionality, just removes a bit of text potentially causing confusion.
While it is true that contexts aren't activated before this event, there is nothing preventing impls from activating them within this event. In fact,
BM#getReferenceexplicitly allows to resolve all beans at this point which means you have to be able to activate contexts anyway.