Add missing copyright headers to Java source files#747
Add missing copyright headers to Java source files#747Ladicek merged 2 commits intojakartaee:mainfrom
Conversation
Copyright owner and date was generated by finding the original author and date from the git history.
|
In this PR, I replicate what @Azquelt did in jakartaee/cdi-tck#528 I generated the 2nd commit using this script: mvn -pl . -fn org.apache.rat:apache-rat-plugin:0.16:check -Drat.excludeSubprojects=false
for F in $(grep -h ????? target/rat.txt | grep \\.java | sed -e 's| !????? ||') ; do
data=$(git log --format="%ae %as" $F | tail -1)
if [[ $data =~ redhat || $data =~ starksm || $data =~ pmuir || $data =~ antoine || $data =~ marlow ]] ; then
company="Red Hat, Inc."
elif [[ $data =~ ibm ]] ; then
company="IBM Corp."
else
exit 1
fi
year=$(echo $data | cut -d ' ' -f 2 | cut -d '-' -f 1)
cat > tmp.txt <<EOF
/*
* Copyright $year, $company, and individual contributors
* by the @authors tag. See the copyright.txt in the distribution for a
* full listing of individual contributors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
* http://www.apache.org/licenses/LICENSE-2.0
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
EOF
cat $F >> tmp.txt
mv tmp.txt $F
done |
|
Running the (somewhat more manual) script I used for jakartaee/cdi-tck#528, I see no differences in the Java files between my workspace and this PR. |
Emily-Jiang
left a comment
There was a problem hiding this comment.
I suggest to use: Eclipse Foundation and individual contributors instead of maintaining a particular company name. In this way, all new files will use the same header. Besides, I don't see any advantages of using a particular company.
|
No. |
|
I think I have expressed my opinion clearly. For Red Hat contributions, obviously the contributors have choose to use the copyright header to Red Hat, which is fine. I |
No description provided.