Revert incorrect change in ambiguity resolution#772
Merged
manovotn merged 1 commit intojakartaee:mainfrom Feb 26, 2024
Merged
Conversation
We previously [1] changed wording in the ambiguity resolution specification from > Return an `Iterator`, that iterates over the set of contextual references > for the resulting beans and required type, as defined in <<contextual_reference>>. to > Return an `Iterator`, that iterates over the set of contextual references > for the resulting beans, as defined in <<contextual_reference>>. This was an attempt to simplify the text, but is in fact incorrect, because a contextual reference is always determined by the bean and the bean type. This commit reverts to the previous wording. [1] jakartaee@74827d2
manovotn
approved these changes
Feb 26, 2024
Contributor
manovotn
left a comment
manovotn
left a comment
There was a problem hiding this comment.
Good catch, I do recall we had that discussion about contextual references but I didn't recall we did this change earlier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously [1] changed wording in the ambiguity resolution specification from
to
This was an attempt to simplify the text, but is in fact incorrect, because a contextual reference is always determined by the bean and the bean type.
This commit reverts to the previous wording.
[1] 74827d2