Skip to content

Allow registering BCE in CDI SE without discovery#817

Merged
manovotn merged 2 commits intojakartaee:mainfrom
manovotn:issue813
Mar 8, 2025
Merged

Allow registering BCE in CDI SE without discovery#817
manovotn merged 2 commits intojakartaee:mainfrom
manovotn:issue813

Conversation

@manovotn
Copy link
Copy Markdown
Contributor

Fixes #813

Adds a new method to SeContainerInitializer which allows users to register build compatible extensions (BCE) without the need for discovery.

I am aware the SeContainerInitializer has two variants of the add method for portable extensions (PE), one of which allows you to pass in pre-initialized PE.
I intentionally skipped that for BCE as those were designed with stricter environments in mind. However, if there is need/want for this we can add it as well.

@manovotn manovotn requested a review from Ladicek May 21, 2024 11:29
@Ladicek
Copy link
Copy Markdown
Member

Ladicek commented May 21, 2024

Apparently the formatter doesn't like the file...?

@manovotn
Copy link
Copy Markdown
Contributor Author

Apparently the formatter doesn't like the file...?

Eh, not just that, I merely forgot to push the rebased version which also adapts tests with dummy initializer impls.
Should be good now.

@manovotn
Copy link
Copy Markdown
Contributor Author

I've also added the specification text (just a mention of the method being there) and created a CDI TCK tracking issue (jakartaee/cdi-tck#585).

@manovotn
Copy link
Copy Markdown
Contributor Author

manovotn commented Mar 8, 2025

I've rebased this against current main since it has been hanging here for a while.
As there was already an approval, I am going to merge this once the CI passes.

@manovotn manovotn merged commit c61cb25 into jakartaee:main Mar 8, 2025
3 checks passed
@manovotn manovotn deleted the issue813 branch March 8, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the ability to register BuildCompatibleExtension in CDI SE without discovery

2 participants