Skip to content

fix: applied updated ESC1 detection logic to other template-based ESCs#264

Merged
jakehildreth merged 4 commits intotestingfrom
fix-other-escs
Sep 10, 2025
Merged

fix: applied updated ESC1 detection logic to other template-based ESCs#264
jakehildreth merged 4 commits intotestingfrom
fix-other-escs

Conversation

@jakehildreth
Copy link
Copy Markdown
Owner

⌘+C, ⌘+V will never lead me astray.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates certificate template-based ESC (Escalation) detection logic by improving Extended Rights validation and making performance optimizations. The changes enhance security validation by adding ObjectType checks for Extended Rights and reduce network timeout values for faster execution.

  • Enhanced Extended Rights validation by adding ObjectType GUID checks across multiple ESC detection functions
  • Reduced HTTP request timeout from 1000ms to 100ms for improved performance
  • Fixed a minor text inconsistency in error messages

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Private/Set-AdditionalCAProperty.ps1 Reduced request timeout and removed commented code
Private/Find-ESC9.ps1 Updated conditional logic to include ObjectType validation for Extended Rights
Private/Find-ESC3C2.ps1 Applied same Enhanced Extended Rights validation pattern
Private/Find-ESC3C1.ps1 Applied same Enhanced Extended Rights validation pattern
Private/Find-ESC2.ps1 Applied same Enhanced Extended Rights validation pattern
Private/Find-ESC16.ps1 Fixed text from "CA" to "template" in error message
Private/Find-ESC15.ps1 Applied same Enhanced Extended Rights validation pattern
Private/Find-ESC13.ps1 Applied Enhanced Extended Rights validation and fixed operator casing
Invoke-Locksmith.ps1 Consolidated all changes from individual files into main script

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread Private/Find-ESC13.ps1 Outdated
Comment thread Invoke-Locksmith.ps1 Outdated
Comment thread Private/Find-ESC16.ps1 Outdated
jakehildreth and others added 3 commits September 8, 2025 18:49
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jakehildreth jakehildreth merged commit 1f76288 into testing Sep 10, 2025
6 checks passed
@jakehildreth jakehildreth deleted the fix-other-escs branch September 10, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants