Update Docker command to use --platform flag#1518
Merged
bakpakin merged 1 commit intojanet-lang:masterfrom Nov 11, 2024
Merged
Conversation
pyrmont
changed the title
--platform flag
Member
|
Lol thank you. I had played around with this but am by no means a docker expert. |
Contributor
Author
|
Hahahaha, I can't take any real credit. I really just copied the fix in yarnpkg/berry#6414 :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beginning with ad77bc3, the following error began occurring in GitHub's test runner when testing with the s390x/ubuntu Docker image:
This may be because s390x/ubuntu images have become an image index and so require a platform specification (see nodejs/docker-node#2110 (comment)).
This PR adds the
--platformflag to the relevant Docker command in the GitHub workflow file to fix this problem.