Tweak some fiber-related docstrings#1708
Merged
bakpakin merged 1 commit intojanet-lang:masterfrom Jan 29, 2026
Merged
Conversation
Member
|
LGTM - there are certainly a number of places where we can both clarify this and enforce it in code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR suggests some changes to some docstrings that mention fibers and/or tasks.
While investigating
ev/cancelvia this Zulip topic, it seemed that the docstring forev/cancelmight be adjusted a bit to match the modified behavior hinted at here.The examination process suggested that possibly some other fiber / task-related docstrings might be changed a bit as well.
The functions / macros in question include:
ev/all-tasksev/callev/cancelev/gatherev/goev/spawnfiber/rootExcept for those of
ev/gather, the changes are about mentioning tasks more explicitly.