chore: improve exceptions quality and add comprehensive tests#85
Open
chore: improve exceptions quality and add comprehensive tests#85
Conversation
- Rename FileIOError to GrindPulseIOError with backward-compat alias - Add required file_path parameter to DataFileNotFoundError and DataFileEmptyError - Add validation for TSVParseError line_number (must be >= 1) - Add comprehensive test suite in tests/python/test_exceptions.py - Update data_parser.py to use new exception signatures - Improve docstrings and error messages
Build Sizetracker.html: 866.28KB Built with Python 3.12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileIOErrortoGrindPulseIOErrorfor clearer namespace scopingfile_patha required parameter inDataFileNotFoundErrorandDataFileEmptyErrorline_number >= 1validation inTSVParseErrorfile_pathtoValidationErrorindata_parser.pydata_parser.pydocstringTest plan
tests/python/test_exceptions.pycover all exception classesfile_pathrequired parameter enforcement verifiedline_numbervalidation boundary conditions testedCloses #23