Replaced some sync methods for their async version#291
Merged
swyxio merged 1 commit intojaredpalmer:masterfrom Dec 4, 2019
Merged
Replaced some sync methods for their async version#291swyxio merged 1 commit intojaredpalmer:masterfrom
swyxio merged 1 commit intojaredpalmer:masterfrom
Conversation
gndelia
force-pushed
the
265-make-things-async
branch
from
11f4c0b to
36b9a03
Compare
Contributor
Author
|
There are some options I was unable to migrate - I think it's not possible. Like the following https://github.com/jaredpalmer/tsdx/blob/master/src/index.ts#L50 and a couple more that are code part of a module and therefore can't be async (that's my understanding) |
Collaborator
|
mm i think we had some merge conflicts from other PRs. if you have time to address them, be my guest, if not i'll try to update when i free up |
gndelia
force-pushed
the
265-make-things-async
branch
from
36b9a03 to
4deb7e2
Compare
Contributor
Author
|
@sw-yx I rebased and solve the conflicts :) |
Collaborator
|
Thank you! |
Collaborator
|
@all-contributors please add @gndelia for code |
Contributor
|
I've put up a pull request to add @gndelia! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #265
I removed most of the sync functions, there are some scenarios which I am unsure what to do. For instance, those sync calls that are at module level (like
src/index.tsline 50 or line 60)Same for
src/errors/transformErrorMessages.ts- I am unsure if I can make that function asyncStill pending one change from
getProjectPath()insrc/index.ts