Skip to content

Fixed path in example#314

Closed
thchia wants to merge 1 commit intojaredpalmer:masterfrom
thchia:template-fix
Closed

Fixed path in example#314
thchia wants to merge 1 commit intojaredpalmer:masterfrom
thchia:template-fix

Conversation

@thchia
Copy link
Copy Markdown

@thchia thchia commented Nov 9, 2019

I'm not sure if I'm missing something, but the import in index.tsx in the react example directory does not point to a valid location. It points to the package root, when I think it should point to either src/index.tsx or dist/index.tsx (but probably the former).

@Carl-Foster
Copy link
Copy Markdown
Contributor

When the path points to the package root, it loads the package from the dist folder, as defined in package.json. This means that the example code runs the compiled components which is ideal for testing.
It's noted in the docs to run both the start command for tsdx and the example package separately to enable this.

@jaredpalmer jaredpalmer closed this Dec 3, 2019
@agilgur5 agilgur5 added the solution: intended behavior This is not a bug and is expected behavior label Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

solution: intended behavior This is not a bug and is expected behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants