(docs/fix): fix ToC changes / bugs introduced in #307#397
Merged
swyxio merged 1 commit intojaredpalmer:masterfrom Dec 28, 2019
Merged
(docs/fix): fix ToC changes / bugs introduced in #307#397swyxio merged 1 commit intojaredpalmer:masterfrom
swyxio merged 1 commit intojaredpalmer:masterfrom
Conversation
- __DEV__ link stopped working - Contributors link didn't work - backtick formatting was removed - this was all re-generated by using `npx doctoc README.md` - doctoc is specified to be used in the ToC comments
Collaborator
Author
|
No clue why windows tests seemed to randomly fail on this PR, especially when I made like 5 PRs in a row, and this is the only one that has failures (in code that wasn't even changed) |
Collaborator
|
not sure why this happens either. here's the failing test so its some sort of filesystem permission issue that is also a race condition? need to investigate and do some trial and error. probably an easy fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__DEV__link stopped workingContributors link didn't work
backtick formatting was removed
this was all re-generated by using
npx doctoc README.mdNoted in #307 (comment) and #307 (comment)