Ensure co-located test files don't have definitions generated

[selbekk]

This commit fixes an issue where type declaration files were created
for test files as well.

Fixes #464

[agilgur5]

Thanks for making the PR!!

Oh, you just changed the templates for this -- I thought you were going to change the TSDX defaults located here:

tsdx/src/createRollupConfig.ts

Line 142 in f12fcdf

tsconfigDefaults: {

It'll be a discussion in any case whether this change is worth merging.

A few comments/changes in any case:

• You are missing a few things from TS's defaults:

  The "exclude" property defaults to excluding the node_modules, bower_components, jspm_packages and <outDir> directories when not specified.

• Why limit to src/ folder? I guess for the templates it makes sense since they only include src/ though (vs. TSDX defaults can be against any include)
• Could you change the title of the PR & commit to something like "Ensure co-located test files don't have definitions generated"? Currently, it's a bit misleading -- test files will only have definitions generated if they're co-located in src/ (the include directory in general); the TSDX convention of using a test/ dir will not encounter this issue

[selbekk]

Updated the list of excludes in all templates. I can centralise in the defaults if you want - especially since the list got a bit longer?

[agilgur5]

Thanks for the changes! In my opinion, I would think it's better to add these universally as it makes the excludes transparent for folks with project structures like yours, and makes no changes to those with test/ directories either. In templates that means people with test/ would have to delete the excludes (or leave them in redundantly); some might also not understand that they're not necessarily needed for all projects.

In any case, let's wait for some thoughts from the other maintainers as they might decline wholesale these changes, idk

[swyxio]

im fine with this

[agilgur5]

@sw-yx any thoughts on adding this to templates vs. adding it to tsconfigDefaults (of rpts2)?

[swyxio]

i dont have strong feelings about this, i can see arguments for both sides. happy to go with whatever you and @selbekk want to do.

[selbekk]

If we add it to the tsconfigDefaults, we can fix this issue for both existing users of tsdx and new ones.

[selbekk]

I'm not sure why this isn't working on the windows-latest build - should work as expected?

[agilgur5]

Some tiny changes:

• add some comments
• paths.appDist is used internally

[swyxio]

@all-contributors pls thank @selbekk for code

[allcontributors]

@sw-yx

I could not determine your intention.

Basic usage: @all-contributors please add @Someone for code, doc and infra

For other usages see the documentation

[agilgur5]

@all-contributors please add @selbekk for code

[allcontributors]

@agilgur5

I've put up a pull request to add @selbekk! 🎉