(fix): check for JSX extension for entry files#474
Merged
swyxio merged 1 commit intojaredpalmer:masterfrom Feb 2, 2020
Merged
Conversation
agilgur5
changed the title
- previously, TS, TSX, and JS were checked, but not JSX
agilgur5
force-pushed
the
fix-jsx-entry
branch
from
9ecfc60 to
0afb462
Compare
Collaborator
Author
|
Recurrence of the missing |
Collaborator
Author
|
Let's give this a try... @all-contributors please add @sisp for bug, code |
Contributor
|
I've put up a pull request to add @sisp! 🎉 |
Collaborator
Author
|
Cool, guess you don't need to be a collaborator to ask the bot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #143 . Credits to @sisp for finding this and providing the suggested solution there. A PR hadn't ever been made and that issue's a bit old; this is related to #473 and #443 so figured it should be done sooner rather than later.