(types): add @types/sade, fix transpileOnly default#476
Merged
jaredpalmer merged 1 commit intojaredpalmer:masterfrom Feb 4, 2020
Merged
(types): add @types/sade, fix transpileOnly default#476jaredpalmer merged 1 commit intojaredpalmer:masterfrom
jaredpalmer merged 1 commit intojaredpalmer:masterfrom
Conversation
Collaborator
Author
|
Huh, this test is failing locally too and I'm not totally sure why 🤔 Is |
- transpileOnly default being the wrong type was found as a result of the better typing - can only be string | number, not boolean
agilgur5
force-pushed
the
sade-types-pre-refactor
branch
from
810bf28 to
9f772e3
Compare
Collaborator
Author
|
Yep, looks like
So changed it to not have a default and modified the conditional |
This was referenced Feb 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the better typing
I originally made this as a follow-up to #407 , as
progis passed around as an argument there (and isanywithout these types), but that hasn't gotten a response in almost a month now 😐 😐So figured I'd separate it out.
Just as a note, the
@types/sadepackage was reviewed by DT, but never got a response from the maintainer, lukeed/sade#27 (comment)