(test): always run build before running tests#493
Merged
swyxio merged 1 commit intojaredpalmer:masterfrom Feb 5, 2020
Merged
Conversation
- personally, I often forget to yarn build before yarn test and that
means I'm testing stale changes
- would be good to have a way to run jest --watch, but that would
optimally require programmatic access to the CLI engine, which
needs some refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
means I'm testing stale changes
optimally require programmatic access to the CLI engine, which
needs some refactoring
Alternative to #492 . Please read that issue for more on test perf improvements we can make to TSDX.
This isn't as robust as #492 but is significantly faster and works the same way as
yarn lint.