(fix): jest config parsing shouldn't silently fail on error#499
Merged
swyxio merged 1 commit intojaredpalmer:masterfrom Feb 7, 2020
Merged
(fix): jest config parsing shouldn't silently fail on error#499swyxio merged 1 commit intojaredpalmer:masterfrom
swyxio merged 1 commit intojaredpalmer:masterfrom
Conversation
- before if your jest.config.js had an error in it, the try/catch would
just ignore it and pretend like your jest.config.js didn't exist
- this caused me a lot of confusion as to why my customizations
seemingly weren't being read at all
- instead of try/catching a MODULE_NOT_FOUND, check if it exists first,
and only then do parsing
- and let it throw an error if there is one, don't cover it up
agilgur5
force-pushed
the
fix-jest-config-parse
branch
from
d21e4cc to
349b98d
Compare
agilgur5
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before if your jest.config.js had an error in it, the try/catch would
just ignore it and pretend like your jest.config.js didn't exist
seemingly weren't being read at all
instead of try/catching a MODULE_NOT_FOUND, check if it exists first,
and only then do parsing
Ran into this while making agilgur5/react-signature-canvas#42 as well, specifically agilgur5/react-signature-canvas@8f124fe
Related to #483 which also had a silent parsing error due to an overbroad try/catch -- should really remove those from the codebase as they cause lots of confusing headaches to users