(refactor): make preset-env variable naming more explicit#643
Merged
agilgur5 merged 1 commit intojaredpalmer:masterfrom Mar 27, 2020
Merged
(refactor): make preset-env variable naming more explicit#643agilgur5 merged 1 commit intojaredpalmer:masterfrom
agilgur5 merged 1 commit intojaredpalmer:masterfrom
Conversation
- I was reading this and was confused which "preset" and "idx" it was talking about (despite having worked on some of the code here myself), so just make it more explicit
agilgur5
commented
Mar 27, 2020
Collaborator
Author
agilgur5
left a comment
agilgur5
left a comment
There was a problem hiding this comment.
yea this is a good bit more understandable IMO
paul-vd
pushed a commit
to EezyQuote/tsdx
that referenced
this pull request
Dec 1, 2020
…r#643) - I was reading this and was confused which "preset" and "idx" it was talking about (despite having worked on some of the code here myself), so just make it more explicit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
talking about (despite having worked on some of the code here
myself), so just make it more explicit