(fix): @types/jest should be a dep, not a devDep#672
Merged
agilgur5 merged 1 commit intojaredpalmer:masterfrom Apr 11, 2020
Merged
(fix): @types/jest should be a dep, not a devDep#672agilgur5 merged 1 commit intojaredpalmer:masterfrom
agilgur5 merged 1 commit intojaredpalmer:masterfrom
Conversation
- per bug report, this caused an issue where the @types/jest that was installed via `create` would have a version mismatch with the jest and jest-related deps used by TSDX - and ts-jest's installation instructions also say to install @types/jest, so it's kind of a peerDep to it - also move @types/shelljs to devDeps as it's not needed for usage of the CLI, it's only used internally
agilgur5
commented
Apr 11, 2020
Collaborator
Author
agilgur5
left a comment
agilgur5
left a comment
There was a problem hiding this comment.
LGTM. Pretty straightforward
Collaborator
Author
|
|
paul-vd
pushed a commit
to EezyQuote/tsdx
that referenced
this pull request
Dec 1, 2020
- per bug report, this caused an issue where the @types/jest that was installed via `create` would have a version mismatch with the jest and jest-related deps used by TSDX - and ts-jest's installation instructions also say to install @types/jest, so it's kind of a peerDep to it - also move @types/shelljs to devDeps as it's not needed for usage of the CLI, it's only used internally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
per bug report, this caused an issue where the @types/jest that was
installed via
createwould have a version mismatch with the jestand jest-related deps used by TSDX
and ts-jest's installation instructions also say to install
@types/jest, so it's kind of a peerDep to it
also move @types/shelljs to devDeps as it's not needed for usage of
the CLI, it's only used internally
Fixes #633 .
@types/jestwas added to the templates in one of the first commits in 9010ecb.Per the issue,
@types/jestwas added as a devDep in #146 when the first TS test was added (makes sense) and@types/shelljswas added as a dep in #244