(clean): remove redundant tsconfig strict opts in templates#673
Merged
agilgur5 merged 1 commit intojaredpalmer:masterfrom Apr 12, 2020
Merged
Conversation
- noImplicitAny, noImplicitThis, alwaysStrict, strictNullChecks,
strictFunctionTypes, and strictPropertyInitialization are already
enabled by strict, no need to configure them twice
- beginners could also be confused by redundant options (like I was
at one point)
- and including them may have also unintentionally encouraged folks
to turn them off
agilgur5
commented
Apr 12, 2020
Collaborator
Author
agilgur5
left a comment
agilgur5
left a comment
There was a problem hiding this comment.
👍 Same removals in all 3 files, only redundant options were removed.
paul-vd
pushed a commit
to EezyQuote/tsdx
that referenced
this pull request
Dec 1, 2020
…mer#673) - noImplicitAny, noImplicitThis, alwaysStrict, strictNullChecks, strictFunctionTypes, and strictPropertyInitialization are already enabled by strict, no need to configure them twice - beginners could also be confused by redundant options (like I was at one point) - and including them may have also unintentionally encouraged folks to turn them off
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strictFunctionTypes, and strictPropertyInitialization are already
enabled by strict, no need to configure them twice
at one point)
to turn them off
Fixes #619 . Similar to removals in #475 but for the external
tsconfigtemplates, instead of just the internal oneSee also my related microsoft/TypeScript-Website#500 that I made when double-checking config options