(deps/types/clean): remove extraneous typings#675
Merged
agilgur5 merged 2 commits intojaredpalmer:masterfrom Apr 12, 2020
Merged
(deps/types/clean): remove extraneous typings#675agilgur5 merged 2 commits intojaredpalmer:masterfrom
agilgur5 merged 2 commits intojaredpalmer:masterfrom
Conversation
- external @types/ are overridden by the package's own internal
typings, so any @types/ packages on top of that are extraneous
- and are usually deprecated too; all are in this case
- execa has had its own typedefs since v2
- the @types/execa package is very dated at v0.9
- ora has had its own typedefs since v3.2
- so @types/ora v3.2 is just a stub
- ansi-escapes has had its own typedefs since v4
- @types/ansi-escapes v4 is just a stub
- camelcase has had its own typedefs since v5.2
- @types/camelcase v5.2 is just a stub
- pin camelcase to v5.2+ from 5.0 to ensure it's a version with
internal typings
- ora also had an unnecessary internal re-declaration too
- as did ansi-escapes and camelcase
- clarify why some of these internal declarations/re-declarations
are necessary
- I tried removing them because I didn't know why they were needed,
so this documentation should be helpful
agilgur5
commented
Apr 12, 2020
Collaborator
Author
agilgur5
left a comment
There was a problem hiding this comment.
LGTM. Remember to rebase this in instead of squash as there's two separate commits (split the docs/comments one out)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
external @types/ are overridden by the package's own internal
typings, so any @types/ packages on top of that are extraneous
execa has had its own typedefs since v2
ora has had its own typedefs since v3.2
ansi-escapes has had its own typedefs since v4
camelcase has had its own typedefs since v5.2
internal typings
ora also had an unnecessary internal re-declaration too
as did ansi-escapes and camelcase
(docs/types): add comments to some remaining declarations
are necessary
so this documentation should be helpful
Hard to say where these made their way in / root cause, seems to have just happened while upgrading / downgrading deps or conversion to TS in #246, #247, #54, and probably some others.