(fix/deps): semver should be a dep, not a devDep#677
Merged
agilgur5 merged 1 commit intojaredpalmer:masterfrom Apr 12, 2020
Merged
(fix/deps): semver should be a dep, not a devDep#677agilgur5 merged 1 commit intojaredpalmer:masterfrom
agilgur5 merged 1 commit intojaredpalmer:masterfrom
Conversation
- it's used in `tsdx create`, definitely not a devDep
- surprised that this hasn't been reported as a bug before, but
probably because it's a subdep of another dep so it finds its way
into most folks' node_modules anyway
agilgur5
commented
Apr 12, 2020
Collaborator
Author
agilgur5
left a comment
agilgur5
left a comment
There was a problem hiding this comment.
LGTM. 1 line moved.
paul-vd
pushed a commit
to EezyQuote/tsdx
that referenced
this pull request
Dec 1, 2020
- it's used in `tsdx create`, definitely not a devDep
- surprised that this hasn't been reported as a bug before, but
probably because it's a subdep of another dep so it finds its way
into most folks' node_modules anyway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tsdx create, definitely not a devDepprobably because it's a subdep of another dep so it finds its way
into most folks' node_modules anyway
Oversight from #433 where it was added as a devDep instead of a dep.
Looks like that only made it into v0.13, so a v0.13.x patch is enough to fix
Incidental finding while upgrading other deps to Node 10+ in #678