-
Notifications
You must be signed in to change notification settings - Fork 503
Add size-limit bundle size analysis tool #705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
6a0bea9
c9567c1
e76ef46
064bc7b
48a1456
a9d4708
73a356e
ce6f47e
b4b8094
3f1156b
49e379f
f7f5bfd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| name: size | ||
| on: [pull_request] | ||
| jobs: | ||
| size: | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| CI_JOB_NUMBER: 1 | ||
|
Comment on lines
+6
to
+7
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what's the purpose of this? I found https://github.com/ai/ci-job-number, but this doesn't run a matrix in any case; there is only one job here.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wasn't able to remember why this was needed 😱 I tried without it and the problem is that size-limit doesn't work properly in the action (it throws an error), so for now is needed. I'll try to investigate more about this
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you have a log of the error? Since this is the only job in this new workflow, making it go first shouldn't be necessary, but maybe the action relies on this variable being specified in order to work |
||
| steps: | ||
| - uses: actions/checkout@v1 | ||
| - uses: andresz1/size-limit-action@v1 | ||
| with: | ||
| github_token: ${{ secrets.GITHUB_TOKEN }} | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| name: size | ||
| on: [pull_request] | ||
| jobs: | ||
| size: | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| CI_JOB_NUMBER: 1 | ||
| steps: | ||
| - uses: actions/checkout@v1 | ||
| - uses: andresz1/size-limit-action@v1 | ||
| with: | ||
| github_token: ${{ secrets.GITHUB_TOKEN }} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| name: size | ||
| on: [pull_request] | ||
| jobs: | ||
| size: | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| CI_JOB_NUMBER: 1 | ||
| steps: | ||
| - uses: actions/checkout@v1 | ||
| - uses: andresz1/size-limit-action@v1 | ||
| with: | ||
| github_token: ${{ secrets.GITHUB_TOKEN }} |
Uh oh!
There was an error while loading. Please reload this page.