(change): update messages.ts github links to formik/ org#754
Merged
jaredpalmer merged 1 commit intojaredpalmer:masterfrom Jul 8, 2020
Merged
(change): update messages.ts github links to formik/ org#754jaredpalmer merged 1 commit intojaredpalmer:masterfrom
jaredpalmer merged 1 commit intojaredpalmer:masterfrom
Conversation
agilgur5
reviewed
Jul 7, 2020
Collaborator
There was a problem hiding this comment.
Makes sense to me. This would be a "change" rather than a "fix" though, as it's not a bugfix. There's some other places that need changing too (also: text says "let me know" instead of "let us know").
Although the entire transfer caught me by surprise as Jared never even told me about it (and has been unresponsive to email for months)... I've also been thinking TSDX deserves its own org for a while as can be seen in some of my comments in various places, particularly for permissions and making new repos, but the latter may well end up being monorepo.
agilgur5
changed the title
agilgur5
changed the title
Collaborator
|
@allcontributors please add @yuriy636 for code |
Contributor
|
I've put up a pull request to add @yuriy636! 🎉 |
paul-vd
pushed a commit
to EezyQuote/tsdx
that referenced
this pull request
Dec 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure how you feel about this, but it surely took me by surprise the first time ("Have I installed the wrong package?")