Filter falsey values from build configs before passing them to rollup#77
Merged
jaredpalmer merged 1 commit intojaredpalmer:masterfrom May 3, 2019
Merged
Conversation
If the `opts.format.includes` call above returns false, a `false` value is inserted into the array in place of a rollup config object. Each element of the `createBuildConfigs` is eventually passed into rollup as an `inputOption`. If one of these elements is `false`, the script will pass that value as a config to rollup which results in a rollup error stating: "You must supply an options object to rollup" This commit fixes that issue by filtering out falsey values.
Collaborator
|
@allcontributors please add @jakegavin for bugs, code |
Contributor
|
I've put up a pull request to add @jakegavin! 🎉 |
joeflateau
pushed a commit
to joeflateau/tsdx
that referenced
this pull request
Nov 12, 2021
* chore: use conventional-commits * chore: release-it config * chore: upgrade husky latest * chore: add commitlint * revert changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #76
I wasn't sure how to write a test for this. Sorry. I'd be happy to write a test if you point me to an example of a similar test that it should look like.
Details copied from commit message: