Fix formatting and lint errors from previous PRs#794
Merged
agilgur5 merged 3 commits intojaredpalmer:masterfrom Aug 14, 2020
Merged
Fix formatting and lint errors from previous PRs#794agilgur5 merged 3 commits intojaredpalmer:masterfrom
agilgur5 merged 3 commits intojaredpalmer:masterfrom
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/formium/tsdx/rdlvaycnh |
agilgur5
commented
Aug 11, 2020
Collaborator
Author
agilgur5
left a comment
agilgur5
left a comment
There was a problem hiding this comment.
LGTM, mostly automated
Collaborator
Author
|
CI is failing on install for certain jobs (race condition) because I accidentally broke upstream |
Collaborator
Author
|
Re-ran CI after my hotfix upstream got merged: bahmutov/npm-install#40 . install on all passed now, but were also all cache hits this time around 🤔 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Commits
format: auto-fix help dialog formatting error
with
yarn lint --fixformatting error is from 8b148ce
format: auto-fix new website formatting errors
with
yarn lint --fixformatting errors are from b09e195
lint: manually fix new website ESLint errors and warnings
these were unable to be auto-fixed, so I had to manually fix them
lint errors are from b09e195
Tags
One is from #734, the rest are from #765 .
This was causing CI errors for basically every PR afterward, mentioned in #762 (review) and #789
Review Notes
Not sure why
nextrahas some of these lint errors built into their examples (lack ofReact,noreferrer, etc), though the project does explicitly say that it is not production ready. Perhaps worth an upstream PR or two.I plan to merge this myself, but in case someone else decides to beforehand, please ensure to rebase (not squash merge) the changes in as they're intentionally 3 separate commits.