clean/deps: remove unused Babel plugins: transform-runtime, dynamic-import#837
Merged
agilgur5 merged 1 commit intojaredpalmer:masterfrom Aug 25, 2020
Merged
Conversation
…mport
- transform-runtime is not used
- its functionality will instead be added by the newer/better
babel-plugin-polyfill-regenerator in a future commit/PR
- move it to devDep as there is an integration test for it
- syntax-dynamic-import is not used
- and it's also included in @babel/preset-env anyway
- these were added in bfc0590 to
support `@wessberg/rollup-plugin-ts` but were not rolled back when
that was rolled back in 3989277
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/formium/tsdx/kbb9t9wcy |
agilgur5
commented
Aug 25, 2020
Collaborator
Author
agilgur5
left a comment
agilgur5
left a comment
There was a problem hiding this comment.
LGTM. 4 LoC change, tests still pass, gonna go out in a minor anyway
paul-vd
pushed a commit
to EezyQuote/tsdx
that referenced
this pull request
Dec 1, 2020
…mport (jaredpalmer#837) - transform-runtime is not used - its functionality will instead be added by the newer/better babel-plugin-polyfill-regenerator in a future commit/PR - move it to devDep as there is an integration test for it - syntax-dynamic-import is not used - and it's also included in @babel/preset-env anyway - these were added in bfc0590 to support `@wessberg/rollup-plugin-ts` but were not rolled back when that was rolled back in 3989277
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
transform-runtime is not used
babel-plugin-polyfill-regenerator in a future commit/PR
syntax-dynamic-import is not used
these were added in Support Async/Await in Rollup Plugins by migrating to
@wessberg/rollup-plugin-ts#208 tosupport
@wessberg/rollup-plugin-tsbut were not rolled back whenthat was rolled back in Rollback #208: Reinstate
rollup-plugin-typescript2#287Tags
In-line above, #795 for
transform-runtimereplacement, #208 and #287 for addition of plugins and lack of removal during rollback.I had noticed
transform-runtimewas unused in #547 (comment) but hadn't fully investigated till now and foundsyntax-dynamic-importalong the way