Fixed testWordExtraction not to depend on installed modules#197
Merged
Holzhaus merged 1 commit intojasperproject:masterfrom Sep 25, 2014
Merged
Fixed testWordExtraction not to depend on installed modules#197Holzhaus merged 1 commit intojasperproject:masterfrom
Holzhaus merged 1 commit intojasperproject:masterfrom
Conversation
There was a problem hiding this comment.
Instead, can we do something like:
words = [
'MUSIC', 'SPOTIFY'
]
mock_module = Mock()
mock_module.WORDS = [
'MOCK'
]
words.extend(mock_module.WORDS)This avoids inconsistencies between WORDS and mock_module.WORDS.
alexsiri7
force-pushed
the
test_fix
branch
2 times, most recently
from
33e744b to
421f331
Compare
Holzhaus
added a commit
that referenced
this pull request
Sep 25, 2014
Fixed testWordExtraction not to depend on installed modules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.