Skip to content

Use config dir for non-temporary writable files#203

Merged
Holzhaus merged 3 commits intojasperproject:masterfrom
Holzhaus:good-riddance-dear-writable-app-dir
Oct 4, 2014
Merged

Use config dir for non-temporary writable files#203
Holzhaus merged 3 commits intojasperproject:masterfrom
Holzhaus:good-riddance-dear-writable-app-dir

Conversation

@Holzhaus
Copy link
Copy Markdown
Member

This is a (partial) fix for issue #119. If this and #181 are merged, we won't need to make the jasper app directory writable anymore, so that jasper can be installed like any other application (into /usr/..., /opt, whatever)

@charliermarsh
Copy link
Copy Markdown

Mmm yeah, that's a good change. Will try to test soon.

We're now using absolute paths and don't need it anymore
@Holzhaus Holzhaus force-pushed the good-riddance-dear-writable-app-dir branch from d2eaf2d to 9c07d49 Compare October 3, 2014 12:14
@charliermarsh
Copy link
Copy Markdown

Tested and everything seems to work. Totally seamless (in that it copies things over to the new directory if necessary), which is really nice. Some of the error-handling code in jasper.py is a little scary, but probably fine to merge in for now.

Holzhaus added a commit that referenced this pull request Oct 4, 2014
…-dir

Use config dir for non-temporary writable files
@Holzhaus Holzhaus merged commit a2939a2 into jasperproject:master Oct 4, 2014
@Holzhaus Holzhaus deleted the good-riddance-dear-writable-app-dir branch October 13, 2014 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants