Fixed convnext tests and nnx warnings#135
Merged
jenriver merged 2 commits intojax-ml:mainfrom Jan 22, 2026
Merged
Conversation
vfdev-5
force-pushed
the
fix-deprwarnings-nnx-state-to-pure-state
branch
from
6ee6ea7 to
8f4f2b2
Compare
vfdev-5
force-pushed
the
fix-deprwarnings-nnx-state-to-pure-state
branch
from
8f4f2b2 to
21fb325
Compare
jenriver
approved these changes
Jan 22, 2026
Member
jenriver
left a comment
jenriver
left a comment
There was a problem hiding this comment.
LGTM, Thanks for the update here!
Mozoltov821
pushed a commit
to Mozoltov821/bonsai
that referenced
this pull request
Feb 3, 2026
Co-authored-by: Jen Ha <25069493+jenriver@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR fixed the following problem:
nnx.Variable.valueis deprecated (DeprecationWarning: '.value' access is now deprecated. For Variable[Array] instances use: variable[...] ...) -> replaced withx[...]in convnext (I haven't searched for other .value usages in the whole codebase)state.to_pure_state()is deprecated (DeprecationWarning:flax.nnx.Statewill be deprecated and be replaced by the built-in Python dict. Please use the equivalentnnx.to_pure_dictinstead.) -> replaced bynnx.to_pure_state(state)error
torch.tensor(jax_array)in convnext (TypeError: the read only flag is not supported, should always be False) -> we have to pass by numpy array as in other tests:torch.tensor(np.asarray(jax_array))added missing
keras_hubto test-env deps in pyproject.toml