Conversation
Signed-off-by: Lee Briggs <lee@leebriggs.co.uk>
Signed-off-by: Lee Briggs <lee@leebriggs.co.uk>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a regression in tscli create key where --tags was accepted for --type authkey but not serialized into the auth-key request payload, and adds coverage/spec updates to prevent recurrence.
Changes:
- Map
--tagsintocapabilities.devices.create.tagsfor auth-key creation requests. - Add an integration regression test asserting auth-key tag serialization in the outgoing JSON payload.
- Update OpenSpec requirements/archive artifacts for auth-key tag behavior and federated key support documentation.
Reviewed changes
Copilot reviewed 10 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
cmd/tscli/create/key/cli.go |
Fixes auth-key request construction to include tags and updates CLI flag/help text. |
test/cli/create_key_flags_integration_test.go |
Adds integration test verifying auth-key tag payload serialization. |
openspec/specs/create-key-authkey-capability-flags/spec.md |
Updates requirements to include --tags in auth-key capability mapping + test expectations. |
openspec/specs/federated-key-support/spec.md |
Adds federated key support specification content. |
openspec/changes/archive/2026-04-10-fix-create-key-tags-parsing/.openspec.yaml |
Adds archive metadata for the tags parsing fix. |
openspec/changes/archive/2026-04-10-fix-create-key-tags-parsing/tasks.md |
Archives tasks for the tags parsing regression fix. |
openspec/changes/archive/2026-04-10-fix-create-key-tags-parsing/proposal.md |
Archives proposal explaining the tags parsing regression and fix. |
openspec/changes/archive/2026-04-10-fix-create-key-tags-parsing/design.md |
Archives design notes for mapping auth-key tags into capabilities. |
openspec/changes/archive/2026-04-10-fix-create-key-tags-parsing/specs/create-key-authkey-capability-flags/spec.md |
Archives the updated auth-key capability flags spec including tags. |
openspec/changes/archive/2026-04-10-federated-tailnet-keys/.openspec.yaml |
Adds archive metadata for federated tailnet keys work. |
openspec/changes/archive/2026-04-10-federated-tailnet-keys/tasks.md |
Archives tasks for federated key support work. |
openspec/changes/archive/2026-04-10-federated-tailnet-keys/proposal.md |
Archives proposal for adding federated key support. |
openspec/changes/archive/2026-04-10-federated-tailnet-keys/design.md |
Archives design notes for federated key support. |
openspec/changes/archive/2026-04-10-federated-tailnet-keys/specs/federated-key-support/spec.md |
Archives federated key support requirements/spec content. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lee Briggs lee@leebriggs.co.uk
Fixes #70