Usecase for `SafeJSON/SafeYAML`

[sewnie]

I have noticed in all types in ghw, there are utility methods for the types to return a JSON or YAML representation that cannot be marshaled back. The only use this has is specific to the ghwc utility, to represent information. Instead, why is there no implementations for json Marshaler and similar for yaml? Additionally, there are more utility functions for representing the values in a safe format for JSON or YAML, which is completely unnecessary as JSON and YAML are both able to translate to and from the values as necessary.

[jaypipes]

@sewnie keep in mind that ghw is >8 years old so choices that were good a long time ago for older versions of Go or the Go standard library may certainly not be good choices for more modern Go. I'm very happy to update ghw to align with more modern Go (this issue and the PR you opened about code organization for testing dependencies...)

If I remember correctly (please excuse my aging brainpower ;) ), I think I originally added the SafeJSON/SafeYAML stuff as a result of the JSON/YAML marshaling of the PCI structs being processed recursively resulting in multi-GB output for some systems. But, I later fixed the recursive marshaling problem using a custom Marshaler but never went back and removed the vestiges of the SafeJSON/SafeYAML stuff.

As we head towards a v1 release of ghw, these are exactly the kinds of things I want to clean up and standardize, so I'd certainly appreciate your contributions in this area. If you want to throw a PR up that removes the SafeYAML/SafeJSON stuff, I'm all for it!