Allow to pass a custom instance of pcidb#415
Merged
jaypipes merged 12 commits intojaypipes:mainfrom Jul 4, 2025
Merged
Conversation
OrbintSoft
force-pushed
the
pass-options-pci
branch
from
2ba17f3 to
3a1b55e
Compare
jaypipes
requested changes
Jul 2, 2025
Owner
jaypipes
left a comment
jaypipes
left a comment
There was a problem hiding this comment.
@OrbintSoft thank you so much for this PR! Really appreciate it :)
Just a nit around the naming of the field in Option, otherwise this is awesome.
Thank you!
jaypipes
changed the title
jaypipes
approved these changes
Jul 3, 2025
Owner
jaypipes
left a comment
jaypipes
left a comment
There was a problem hiding this comment.
Awesome, thank you so much @OrbintSoft, welcome to the ghw contributor club! :)
jaypipes
requested changes
Jul 3, 2025
OrbintSoft
force-pushed
the
pass-options-pci
branch
from
0b5b0f1 to
fdb3953
Compare
jaypipes
approved these changes
Jul 4, 2025
jaypipes
reviewed
Jul 4, 2025
jaypipes
reviewed
Jul 4, 2025
jaypipes
approved these changes
Jul 4, 2025
Owner
|
Thanks for your patience @OrbintSoft and thank you for your contribution! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ghw doesn't allow to pass options to pcidb, So I added the possibility to pass a custom istance