Skip to content

fix: only mark non-rotational HDDs as SSD #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaypipes merged 2 commits into from
Aug 14, 2025
Merged

fix: only mark non-rotational HDDs as SSD #422

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
066e436
fix: only mark non-rotational HDDs as SSD
dudyas6 Aug 14, 2025
7ba5253
Add comment to explain the change in behaviour
dudyas6 Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkg/block/block_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,10 @@ func disks(ctx *context.Context, paths *linuxpath.Paths) []*Disk {
driveType, storageController := diskTypes(dname)
// TODO(jaypipes): Move this into diskTypes() once abstracting
// diskIsRotational for ease of unit testing
if !diskIsRotational(ctx, paths, dname) {
// Only reclassify HDD to SSD if non-rotational to avoid changing already correct types.
// This addresses changed kernel behavior where rotational detection may be unreliable,
// where some kernels report CD-ROM drives as non-rotational, incorrectly classifying them as SSD.
if !diskIsRotational(ctx, paths, dname) && driveType == DRIVE_TYPE_HDD {
driveType = DRIVE_TYPE_SSD
}
size := diskSizeBytes(paths, dname)
Expand Down