pci: add iommu group#430
Conversation
|
Unfortunately the testdata snapshots are missing I am not sure if I should add another snapshot from my laptop? |
@christoph-zededa yep, go for it! :) |
christoph-zededa
force-pushed
the
pci_iommu_group
branch
2 times, most recently
from
d749e83 to
a132eea
Compare
done. |
jaypipes
left a comment
jaypipes
left a comment
There was a problem hiding this comment.
couple tiny requests inline, thank you @christoph-zededa :)
| Driver string `json:"driver"` | ||
| Node *topology.Node `json:"node,omitempty"` | ||
| Driver string `json:"driver"` | ||
| IommuGroup string `json:"iommu_group"` |
There was a problem hiding this comment.
| IommuGroup string `json:"iommu_group"` | |
| IOMMUGroup string `json:"iommu_group"` |
See here for a discussion on naming conventions for Initialisms in Go.
There was a problem hiding this comment.
Also, if you could add a code comment above IOMMUGroup that explains the field's value, including perhaps a link to this document.
There was a problem hiding this comment.
I changed it to IOMMUGroup and I added the link.
christoph-zededa
force-pushed
the
pci_iommu_group
branch
3 times, most recently
from
c659bac to
e22af2b
Compare
|
@christoph-zededa not entirely sure what happened to this PR... did you push commits from a different branch into yours? Typically what you want to do is |
this snapshot includes the iommu_group of the pci devices, so that it can be tested from the go tests. Signed-off-by: Christoph Ostarek <christoph@zededa.com>
the iommu group is important when using pci-passthrough as the whole group has to be passed through (unless using some hacks). Therefore it is an important piece of information that should be part of `pci.Device`. Signed-off-by: Christoph Ostarek <christoph@zededa.com>
christoph-zededa
force-pushed
the
pci_iommu_group
branch
from
e22af2b to
f74a86b
Compare
Hmm, weird. Now it looks ok to me (i.e. 2 commits in this PR). |
jaypipes
left a comment
jaypipes
left a comment
There was a problem hiding this comment.
👍 thank you @christoph-zededa! :)
thank you for the help and your review :-) |
2 participants
the iommu group is important when using pci-passthrough as the whole group has to be passed through (unless using some hacks). Therefore it is an important piece of information that should be part of
pci.Device.