Add WithDisableTopology option to reduce memory consumption#432
Add WithDisableTopology option to reduce memory consumption#432halfcrazy wants to merge 1 commit intojaypipes:mainfrom
Conversation
f456afd to
c569fcb
Compare
|
xref #354 |
|
Hi @halfcrazy sorry this has lagged. I will have to rework this PR due to a refactoring that recently merged as we head towards a 1.0 release of ghw. I will try to get to the reworking of this PR this weekend. |
d16c5ed to
2b168d0
Compare
| } | ||
| info.arch = topo.Architecture | ||
| } | ||
| if opts.PCIDB != nil { |
There was a problem hiding this comment.
I found options.PCIDB no longer used, i'm not sure if this is expected.
There was a problem hiding this comment.
Author
@halfcrazy yes, we've totally changed the way that options and context are handled. I will rework this PR soon, I promise. sorry for the delay.
This commit adds a new WithDisableTopology() option that allows users to skip system topology detection when calling ghw.PCI() or ghw.GPU(), significantly reducing memory consumption for use cases that don't require NUMA topology information. Signed-off-by: Yan Zhu <hackzhuyan@gmail.com>
2b168d0 to
4a49a69
Compare
jaypipes
left a comment
There was a problem hiding this comment.
@halfcrazy sorry it took so long, but I rebased and fixed up your commit to use the latest config/context handling:
thank you |
This commit adds a new WithDisableTopology() option that allows users to skip system topology detection when calling ghw.PCI() or ghw.GPU(), significantly reducing memory consumption for use cases that don't require NUMA topology information.
Performance impact on real production servers: