Skip to content

Update load() stub to accept options parameter#445

Merged
jaypipes merged 1 commit intojaypipes:mainfrom
davidnewhall:patch-1
Feb 8, 2026
Merged

Update load() stub to accept options parameter#445
jaypipes merged 1 commit intojaypipes:mainfrom
davidnewhall:patch-1

Conversation

@davidnewhall
Copy link
Copy Markdown
Contributor

Allows this library to compile on what I assume are unsupported operating systems. The latest release breaks usage on FreeBSD, this fixes it. You're welcome to reject this and fix it your own way. Thanks!

Allows this library to compile on what I assume are unsupported operating systems. The latest release breaks usage on FreeBSD, this fixes it.

Signed-off-by: David Newhall II <david@sleepers.pro>
@davidnewhall
Copy link
Copy Markdown
Contributor Author

I looked through your GitHub workflows a bit. You could add a simple GOOS=freebsd go build ./... step somewhere to catch this regression.

@jaypipes
Copy link
Copy Markdown
Owner

jaypipes commented Feb 8, 2026

@davidnewhall thank you so much for this. Really appreciate it! Unfortunately, I haven't had an opportunity to add any testing or support for FreeBSD. This is just the kick I needed to get that effort going :)

@jaypipes jaypipes merged commit 3b1ff63 into jaypipes:main Feb 8, 2026
14 checks passed
@davidnewhall
Copy link
Copy Markdown
Contributor Author

@jaypipes I screwed up. I didn't actually test this specific change. I added this in my IDE and it added the import for me. I didn't notice. So this is still a problem. The file needs an import line added for option. I'll open another PR shortly.

@jaypipes
Copy link
Copy Markdown
Owner

jaypipes commented Feb 9, 2026

@jaypipes I screwed up. I didn't actually test this specific change. I added this in my IDE and it added the import for me. I didn't notice. So this is still a problem. The file needs an import line added for option. I'll open another PR shortly.

No worries @davidnewhall :) I've merged the fix and I'll cut a new release shortly after merging some other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants