Skip to content

test: improve Vimeo thumbnail URL assertion by ignoring query params#228

Merged
aleksihakli merged 4 commits intojazzband:masterfrom
mgrdcm:vimeo-test-parts
Mar 16, 2026
Merged

test: improve Vimeo thumbnail URL assertion by ignoring query params#228
aleksihakli merged 4 commits intojazzband:masterfrom
mgrdcm:vimeo-test-parts

Conversation

@mgrdcm
Copy link
Copy Markdown
Member

@mgrdcm mgrdcm commented Feb 13, 2026

Another change pulled from @mahdirahimi1999's #214

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.11%. Comparing base (07acd44) to head (2ffdee1).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #228   +/-   ##
=======================================
  Coverage   99.10%   99.11%           
=======================================
  Files          16       16           
  Lines         671      676    +5     
  Branches       40       40           
=======================================
+ Hits          665      670    +5     
  Misses          4        4           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mgrdcm mgrdcm marked this pull request as ready for review February 13, 2026 23:05
Copy link
Copy Markdown
Member

@aleksihakli aleksihakli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aleksihakli aleksihakli merged commit 2b64498 into jazzband:master Mar 16, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants