feat: add conv1d_fn op for Qwen3.5 linear attention on NPU.#1295
Merged
yingxudeng merged 1 commit intojd-opensource:mainfrom Apr 19, 2026
Merged
feat: add conv1d_fn op for Qwen3.5 linear attention on NPU.#1295yingxudeng merged 1 commit intojd-opensource:mainfrom
yingxudeng merged 1 commit intojd-opensource:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements the causal_conv1d kernel for NPU and integrates it into the Qwen3GatedDeltaNetBase layer, alongside adding a comprehensive NPU helper utility. The review feedback highlights several style guide violations regarding member variable naming, type aliases, casting, and assertion macros. Critical issues were identified concerning an uninitialized variable in the layer implementation and the presence of debugging logs in production code. Furthermore, performance improvements are suggested to address synchronous device-to-host transfers and inefficient data handling in the worker implementation.
maojunx99
requested review from
DongheJin,
JimHsiung,
RobbieLeung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
Collaborator
格式检查麻烦改下
|
yingxudeng
reviewed
Apr 16, 2026
maojunx99
force-pushed
the
conv1d_fn
branch
2 times, most recently
from
56e4ad5 to
7ce6e47
Compare
yingxudeng
reviewed
Apr 17, 2026
Collaborator
|
xllm_ops 仓库的 commit 貌似需要更新下 |
yingxudeng
reviewed
Apr 17, 2026
yingxudeng
changed the title
yingxudeng
approved these changes
Apr 18, 2026
zhang-minchao
approved these changes
Apr 18, 2026
liutongxuan
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add new conv1d_fn op interface