Skip to content

fix(gitlab): resolve tool options from config for aliased tools #8084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 2 commits into from
Feb 10, 2026
Merged

fix(gitlab): resolve tool options from config for aliased tools #8084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c77d3e1
fix(gitlab): resolve tool options from config for aliased tools
jdx Feb 10, 2026
8c3ba8e
test(gitlab): add e2e test for tool alias option propagation
jdx Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions e2e/backend/test_gitlab
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,21 @@ PLATFORM_KEY=$(mise x --cd . -- bash -c "echo \"\$(uname -s | tr '[:upper:]' '[:
assert_contains "cat mise.lock" "\"platforms.$PLATFORM_KEY\""
assert_contains "cat mise.lock" 'checksum = "blake3:71f774faa03daf1a58cc3339f8c73e6557348c8e0a2f3fb8148cc26e26bad83f"'
assert_contains "cat mise.lock" 'url = "https://mise.jdx.dev/test-fixtures/hello-world-1.0.0.tar.gz"'

mise uninstall gitlab:jdxcode/mise-test-fixtures

# Test GitLab backend with tool alias propagates options correctly
# Regression test for https://github.com/jdx/mise/discussions/8079
cat <<EOF >mise.toml
[tools]
"gitlab:jdxcode/mise-test-fixtures" = { version = "1.0.0", asset_pattern = "hello-world-1.0.0.tar.gz", bin_path = "hello-world-1.0.0/bin", postinstall = "chmod +x \$MISE_TOOL_INSTALL_PATH/hello-world-1.0.0/bin/hello-world" }

[tool_alias]
my-test-tool = 'gitlab:jdxcode/mise-test-fixtures'
EOF

# Verify ls-remote works via alias (exercises _list_remote_versions with get_tool_opts)
assert_contains "mise ls-remote my-test-tool" "1.0.0"

mise install
assert_contains "mise x my-test-tool -- hello-world" "hello world"
74 changes: 47 additions & 27 deletions src/backend/github.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,10 +139,13 @@ impl Backend for UnifiedGitBackend {
features
}

async fn _list_remote_versions(&self, _config: &Arc<Config>) -> Result<Vec<VersionInfo>> {
async fn _list_remote_versions(&self, config: &Arc<Config>) -> Result<Vec<VersionInfo>> {
let repo = self.ba.tool_name();
let id = self.ba.to_string();
let opts = self.ba.opts();
let opts = config
.get_tool_opts(&self.ba)
.await?
.unwrap_or_else(|| self.ba.opts());
let api_url = self.get_api_url(&opts);
let version_prefix = opts.get("version_prefix");

Expand Down Expand Up @@ -178,7 +181,7 @@ impl Backend for UnifiedGitBackend {
.into_iter()
.filter(|r| version_prefix.is_none_or(|p| r.tag_name.starts_with(p)))
.map(|r| VersionInfo {
version: self.strip_version_prefix(&r.tag_name),
version: self.strip_version_prefix(&r.tag_name, &opts),
created_at: r.released_at,
release_url: Some(format!("{}/-/releases/{}", web_url_base, r.tag_name)),
..Default::default()
Expand All @@ -190,7 +193,7 @@ impl Backend for UnifiedGitBackend {
.into_iter()
.filter(|r| version_prefix.is_none_or(|p| r.tag_name.starts_with(p)))
.map(|r| VersionInfo {
version: self.strip_version_prefix(&r.tag_name),
version: self.strip_version_prefix(&r.tag_name, &opts),
created_at: Some(r.created_at),
release_url: Some(format!("{}/releases/tag/{}", web_url_base, r.tag_name)),
..Default::default()
Expand All @@ -202,7 +205,7 @@ impl Backend for UnifiedGitBackend {
.into_iter()
.filter(|r| version_prefix.is_none_or(|p| r.tag_name.starts_with(p)))
.map(|r| VersionInfo {
version: self.strip_version_prefix(&r.tag_name),
version: self.strip_version_prefix(&r.tag_name, &opts),
created_at: Some(r.created_at),
release_url: Some(format!("{}/releases/tag/{}", web_url_base, r.tag_name)),
..Default::default()
Expand Down Expand Up @@ -232,7 +235,11 @@ impl Backend for UnifiedGitBackend {
mut tv: ToolVersion,
) -> Result<ToolVersion> {
let repo = self.repo();
let opts = tv.request.options();
let opts = ctx
.config
.get_tool_opts(&self.ba)
.await?
.unwrap_or_else(|| tv.request.options());
let api_url = self.get_api_url(&opts);

// Check if URL already exists in lockfile platforms first
Expand Down Expand Up @@ -921,9 +928,7 @@ impl UnifiedGitBackend {
}
}

fn strip_version_prefix(&self, tag_name: &str) -> String {
let opts = self.ba.opts();

fn strip_version_prefix(&self, tag_name: &str, opts: &ToolVersionOptions) -> String {
// If a custom version_prefix is configured, strip it first
if let Some(prefix) = opts.get("version_prefix")
&& let Some(stripped) = tag_name.strip_prefix(prefix)
Expand Down Expand Up @@ -1339,7 +1344,7 @@ fn template_string_for_target(template: &str, tv: &ToolVersion, target: &Platfor
#[cfg(test)]
mod tests {
use super::*;
use crate::cli::args::{BackendArg, BackendResolution};
use crate::cli::args::BackendArg;

fn create_test_backend() -> UnifiedGitBackend {
UnifiedGitBackend::from_arg(BackendArg::new(
Expand All @@ -1357,41 +1362,56 @@ mod tests {

#[test]
fn test_version_prefix_functionality() {
let mut backend = create_test_backend();
let backend = create_test_backend();
let default_opts = ToolVersionOptions::default();

// Test with no version prefix configured
assert_eq!(backend.strip_version_prefix("v1.0.0"), "1.0.0");
assert_eq!(backend.strip_version_prefix("1.0.0"), "1.0.0");
assert_eq!(
backend.strip_version_prefix("v1.0.0", &default_opts),
"1.0.0"
);
assert_eq!(
backend.strip_version_prefix("1.0.0", &default_opts),
"1.0.0"
);

// Test projectname@version format - only strips if prefix matches repo name
// Backend uses "github:test/repo" so repo short name is "repo", full name is "test/repo"
assert_eq!(backend.strip_version_prefix("repo@0.15.0"), "0.15.0");
assert_eq!(backend.strip_version_prefix("repo@1.2.3"), "1.2.3");
assert_eq!(
backend.strip_version_prefix("repo@0.15.0", &default_opts),
"0.15.0"
);
assert_eq!(
backend.strip_version_prefix("repo@1.2.3", &default_opts),
"1.2.3"
);
// Also accepts full repo name as prefix
assert_eq!(backend.strip_version_prefix("test/repo@2.0.0"), "2.0.0");
assert_eq!(
backend.strip_version_prefix("test/repo@2.0.0", &default_opts),
"2.0.0"
);
// Should NOT strip if prefix doesn't match repo name (prevents listing
// versions that can't be installed)
assert_eq!(
backend.strip_version_prefix("other_package@0.15.0"),
backend.strip_version_prefix("other_package@0.15.0", &default_opts),
"other_package@0.15.0"
);
// Should not match if part after @ doesn't start with a digit
assert_eq!(backend.strip_version_prefix("repo@beta"), "repo@beta");
assert_eq!(
backend.strip_version_prefix("repo@beta", &default_opts),
"repo@beta"
);

// Test with custom version prefix
let mut opts = ToolVersionOptions::default();
opts.opts
.insert("version_prefix".to_string(), "release-".to_string());
backend.ba = Arc::new(BackendArg::new_raw(
"test".to_string(),
Some("github:test/repo".to_string()),
"test".to_string(),
Some(opts),
BackendResolution::new(true),
));

assert_eq!(backend.strip_version_prefix("release-1.0.0"), "1.0.0");
assert_eq!(backend.strip_version_prefix("1.0.0"), "1.0.0");
assert_eq!(
backend.strip_version_prefix("release-1.0.0", &opts),
"1.0.0"
);
assert_eq!(backend.strip_version_prefix("1.0.0", &opts), "1.0.0");
}

#[test]
Expand Down
12 changes: 11 additions & 1 deletion src/config/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,17 @@ impl Config {
backend_arg: &Arc<BackendArg>,
) -> Result<Option<ToolVersionOptions>> {
let trs = self.get_tool_request_set().await?;
let tool_request = trs.iter().find(|tr| tr.0.short == backend_arg.short);
// Try matching by resolved full name first for aliased tools.
// e.g., ba.short="treesize" resolves to full="gitlab:FBibonne/treesize"
// while the config entry has short="gitlab-f-bibonne-treesize" with api_url set.
// We check the resolved name first because the direct short match might find
// a CLI-created tool request without options.
let full = backend_arg.full();
let resolved_ba = BackendArg::new(full, None);
let tool_request = trs
.iter()
.find(|tr| tr.0.short == resolved_ba.short)
.or_else(|| trs.iter().find(|tr| tr.0.short == backend_arg.short));
Ok(tool_request.and_then(|tr| tr.1.first().map(|req| req.options())))
}

Expand Down
Loading