refactor: use enum for npm.pacakge_manager

[risu729]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @risu729, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the robustness and maintainability of the npm.package_manager configuration by converting it from a free-form string to a strongly typed enum. This change ensures that only predefined and valid package managers can be specified, reducing potential errors and making the codebase more explicit. The necessary adjustments have been made across the configuration schema, settings file, and the core backend logic to fully integrate this new enum-based approach.

Highlights

• Type Safety Improvement: The npm.package_manager setting has been refactored from a string to a Rust enum, enhancing type safety and preventing invalid package manager configurations.
• Schema and Configuration Updates: The schema/mise.json and settings.toml files were updated to reflect the new enum structure, explicitly listing 'npm', 'bun', and 'pnpm' as valid options.
• Backend Logic Adaptation: The src/backend/npm.rs file was modified to utilize the new NpmPackageManager enum for all package manager comparisons and installation logic.
• Build System Integration: A rerun-if-changed directive was added to build.rs to ensure the build script is re-executed when settings.toml is modified.

Changelog

• build.rs
  • Added a println! macro to trigger a rerun of the build script if settings.toml changes.
• schema/mise.json
  • Restricted the package_manager property to an enumerated list of 'npm', 'bun', and 'pnpm'.
• settings.toml
  • Added enum and rust_type fields to the npm.package_manager definition, specifying allowed values and the corresponding Rust enum type.
• src/backend/npm.rs
  • Imported the new NpmPackageManager enum.
  • Updated package_manager comparisons and assignments to use the NpmPackageManager enum variants instead of string literals.
  • Modified string comparison for tool_name to use package_manager.to_string().
• src/config/settings.rs
  • Defined a new NpmPackageManager enum with Npm, Bun, and Pnpm variants, including necessary traits for serialization, deserialization, and string conversion.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a nice refactoring that replaces the string-based npm.package_manager setting with a strongly-typed enum, NpmPackageManager. This improves type safety and code clarity across the board, from settings definition and parsing to the logic within the NPMBackend. The changes in settings.toml, schema/mise.json, and the build script are all correct and support this refactoring.

I've added a few suggestions in src/backend/npm.rs to make the match statements on the new enum exhaustive by replacing wildcard _ patterns with explicit enum variants. This will improve maintainability and leverage compiler checks for future changes.

[Copilot]

Pull request overview

This PR refactors the npm package manager configuration from using a plain string to using a proper enum type (NpmPackageManager). This change improves type safety and ensures only valid package managers (npm, bun, pnpm) can be configured.

Changes:

• Introduced NpmPackageManager enum with three variants: Npm, Bun, and Pnpm
• Updated all references to npm.package_manager throughout the codebase to use the enum type
• Added enum constraints to the JSON schema and settings.toml configuration

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/config/settings.rs	Defines the new NpmPackageManager enum with proper derives and serialization attributes
src/backend/npm.rs	Updates all package manager logic to use the enum instead of string comparisons
settings.toml	Adds enum constraint and rust_type specification for the package_manager setting
schema/mise.json	Adds JSON schema enum constraint for package_manager field
build.rs	Adds cargo rerun directive for settings.toml changes

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.